Fix #6213: Convert RefinedTypeTrees to TypeTrees in ReTyper #6249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard treatment of RefinedTypeTrees creates a class definition, typechecks it and then extracts the type from that. The class definition does not form part of the resulting tree. This treatment is not workable for ReTyper since ReTyper is not prepared to typecheck fresh class definitions from scratch. We avoid the problem by having ReTyper convert the RefinedTypeTree to a TypeTree instead, keeping just the type. Note: The only reason why Typer does not do the same thing is so that we can keep the refinements as trees for IDE navigation. But that's not necessary for trees that have undergone a ReTyper step (i.e. typically inlined trees).
|
LGTM ... I was close, but I missed that it would be safe to convert the |
milessabin
approved these changes
Apr 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard treatment of RefinedTypeTrees creates a class definition, typechecks it
and then extracts the type from that. The class definition does not form part of the
resulting tree. This treatment is not workable for ReTyper since ReTyper is not prepared
to typecheck fresh class definitions from scratch. We avoid the problem by having
ReTyper convert the RefinedTypeTree to a TypeTree instead, keeping just the type.
Note: The only reason why Typer does not do the same thing is so that we can keep
the refinements as trees for IDE navigation. But that's not necessary for trees
that have undergone a ReTyper step (i.e. typically inlined trees).