Fix Scope.exists and some missing Inlined trees #6233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-scope-exists
branch
3 times, most recently
from
948f071 to
841f815
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
fix-scope-exists
branch
from
32d158c to
e219f7e
Compare
|
Rebased |
liufengyun
approved these changes
Apr 7, 2019
| else (call.symbol.unforcedDecls.exists(_.is(Macro)) || call.symbol.unforcedDecls.toList.exists(_.is(Macro))) | ||
| if (ctx.phase <= ctx.postTyperPhase) call.symbol.is(Macro) | ||
| else call.isInstanceOf[Select] // The call of a macro after typer is encoded as a Select while other inlines are Ident | ||
| // TODO remove this distinction once Inline nodes of expanded macros can be trusted (also in Inliner.inlineCallTrace) |
There was a problem hiding this comment.
Looking at the method alone, call.isInstanceOf[Select] seems to be a too weak test.
There was a problem hiding this comment.
This is a heuristic to know if we should YCheck the positions inside this Inlined tree or not.
There was a problem hiding this comment.
At some point we will test the contents of these Inlined trees. Then this test would be removed.
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.