Fix pruning when adding a constraint #6204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variance in the code was exactly the opposite of what was claimed in the comment. The reasoning in the comment was right.
|
@milessabin: This PR should fix the implicit functor test case. It was a wrong flag for the variance of an approximation that is needed in the case where we compare type lambdas like Can you check whether this fixes your original non-minimized test case as well? |
|
@odersky thanks for digging in to this! Yes, it does fix the unminimized case as well :-) |
milessabin
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variance in the code was exactly the opposite of what was claimed
in the comment. The reasoning in the comment was right.