Fix #6064: Hardening in the presence of kind mismatches #6100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three fixes for when the number of type-parameters disagrees with the number of type arguments. One is in TypeAccumulator, two more are in Substituters. There's a tricky balance here. On the one hand, crashing early on mismatches is an excellent means to pinpoint errors in the compiler. On the other hand, it makes legal but nonsensical programs crash the compiler. So, we should do the minimum so that "on the other hand" is not observed. Which means doing this driven by counter-examples (coming from fuzzing or elsewhere) is not a bad way to tackle the problem.
smarter
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three fixes for when the number of type-parameters disagrees with the number of type arguments.
One is in TypeAccumulator, two more are in Substituters.
There's a tricky balance here. On the one hand, crashing early on mismatches is
an excellent means to pinpoint errors in the compiler. On the other hand,
it makes malformed input crash the compiler. So, we should
do the minimum so that "on the other hand" is not observed. Which means doing
this driven by counter-examples (coming from fuzzing or elsewhere) is not a
bad way to tackle the problem.