-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #5986: Add autolift implicit conversion #6038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think that's fine since normally we do not care whether something is lifted or not. import scala.quoted.{autolift => _, _} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add this to principled-meta-programming.md
. Probably a new paragraph at the end of the The Liftable type-class
section.
Could you also change the commit message to |
Rebased, updated the doc and left the automatic way out for now. |
Add an
autolift
implicit conversion and update tests.Eliminating
.toExpr
doesn't give always good intuition about what kind of values exist inside a splice.For example with
autolift
the following code hasx
in both cases. One of them is implicitly lifted and the other is not 😛.WDYT?