Skip to content

Avoid spurious pure expression warning with ErrorTypes #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2019
Merged

Avoid spurious pure expression warning with ErrorTypes #5942

merged 2 commits into from
Feb 18, 2019

Conversation

smarter
Copy link
Member

@smarter smarter commented Feb 18, 2019 •
edited
Loading

The .widen before calling .isErroneous is needed to recognize broken.foo as erroneous, not sure if we should change the definition of .isErroneous to widen automatically.

@smarter smarter added this to the 0.13 Tech Preview milestone Feb 18, 2019
@smarter smarter requested a review from odersky February 18, 2019 12:00
odersky
odersky requested changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to widen as part of _.isErroneous. It's too easy to fall into this trap otherwise.

@odersky odersky assigned smarter and unassigned odersky Feb 18, 2019
@smarter smarter merged commit ef55202 into scala:master Feb 18, 2019
@allanrenucci allanrenucci deleted the fix-pure-expr branch February 18, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky requested changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
0.13 Tech Preview
Development

Successfully merging this pull request may close these issues.
2 participants
@smarter @odersky