Fix #5857: handle qualified private/protected case class constructor #5908
+106
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jasper-M
commented
Feb 12, 2019
Jasper-M
commented
- apply inherits qualified private access modifiers
- copy inherits qualified private/protected access modifiers
dottybot
reviewed
Feb 12, 2019
smarter
requested changes
Feb 19, 2019
|
Please squash and also rebase (to pick up the changes to our CI which now runs the community build too) |
|
Should be ok now. |
smarter
approved these changes
Feb 19, 2019
There was a problem hiding this comment.
One last thing: please copy the added testcases from https://github.com/scala/scala/pull/7702/files since they seem more thorough, otherwise 👍 , thanks for your work !
…ctor - apply inherits qualified private access modifiers - copy inherits qualified private/protected access modifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.