Worksheet: improve hover support #5900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to resolve one TODO.
Instead of having a positionMapper argument for `range`, `location`, etc, choose the right `positionMapper` in range directly
currentCtx is a def which is updated after each run, so when making it available implicitly, we shouldn't use a val.
This command is sent from the server to the client when a statement in the current worksheet has finished running, but statements can be multi-line so returning just the line number loses some information. We use this extra information in vscode-dotty so that the hover pop-up containing the output of the statement is displayed when hovering over any part of the statement, and not just the last line. To avoid breaking this hover pop-up when using an old version of Dotty, some compatibiltiy code is necessary.
nicolasstucki
approved these changes
Feb 14, 2019
language-server/src/dotty/tools/languageserver/worksheet/Worksheet.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hovering on any part of a statement now displays the worksheet output for this statement in a popup if available, this improves on the existing behavior where this only happened when hovering over the last line of the statement. This required changing the worksheet/publishOutput command to return a range rather than a line number.
Also upgrade dependencies and minor changes in the language server.