Fix null unboxing of primitives (fixes #582) #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erasure#isUnbox was incorrect: the unbox methods are defined on the value classes, not the boxed classes.
| @@ -1,11 +0,0 @@ | |||
| object Test { | |||
There was a problem hiding this comment.
for future reference, you can just write extends dotty.runtime.LegacyApp and body will be executed.
There was a problem hiding this comment.
Do we want to do this for new tests to? I thought LegacyApp was only a compatiblity hack.
There was a problem hiding this comment.
That's a compatibility adaptor that works only if you do not inspect arguments. And that is the current situation with run tests.
|
LGTM. |
DarkDimius
added a commit
that referenced
this pull request
May 17, 2015
Fix null unboxing of primitives (fixes #582)
|
Note that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erasure#isUnbox was incorrect: the unbox methods are defined on the
value classes, not the boxed classes.
Review by @DarkDimius.