Skip to content

Fix #5770: Add JavaDefined to tasty reflect #5777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2019
Merged

Fix #5770: Add JavaDefined to tasty reflect #5777

merged 2 commits into from
Jan 23, 2019

Conversation

liufengyun
Copy link
Contributor

Fix #5770: Add JavaDefined to tasty reflect

nicolasstucki
nicolasstucki suggested changes Jan 22, 2019
View reviewed changes
nicolasstucki
nicolasstucki reviewed Jan 22, 2019
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the showFlags method in scala.tasty.reflect.Printers. Otherwise LGTM

@nicolasstucki
Copy link
Contributor

You need to update the 2 showFlags methods in scala.tasty.reflect.Printers. Otherwise LGTM

nicolasstucki
nicolasstucki reviewed Jan 22, 2019
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the 2 showFlags methods in scala.tasty.reflect.Printers. Otherwise LGTM

@nicolasstucki nicolasstucki merged commit 9a439d9 into scala:master Jan 23, 2019
@nicolasstucki nicolasstucki deleted the fix-5770 branch January 23, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liufengyun @nicolasstucki