Make Child annotation lazy #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we get bootstrap problems when trying to compile Child: Completing Predef with the Scala2Unpickler causes Child annotations to be added to parents of case classes. But completing Child would depend on completion of Predef. Making child annotations lazy avoids the cycle.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we get bootstrap problems when trying to compile Child:
Completing Predef with the Scala2Unpickler causes Child annotations
to be added to parents of case classes. But completing Child would depend
on completion of Predef. Making child annotations lazy avoids the cycle.
Review by @DarkDimius