Fix #5032: Make sure that erroneous empty idents have a position #5706

nicolasstucki · 2019-01-15T07:28:47Z

No description provided.

compiler/src/dotty/tools/dotc/parsing/Parsers.scala

Rebased and refactored to work on typeIdent

nicolasstucki assigned odersky Jan 15, 2019

nicolasstucki added the stat:needs review label Jan 15, 2019

nicolasstucki requested a review from odersky January 15, 2019 09:12

odersky previously requested changes Jan 15, 2019

View reviewed changes

compiler/src/dotty/tools/dotc/parsing/Parsers.scala Outdated Show resolved Hide resolved

odersky assigned nicolasstucki and unassigned odersky Jan 15, 2019

odersky removed the stat:needs review label Jan 15, 2019

nicolasstucki added stat:on hold and removed stat:on hold labels Jan 15, 2019

Fix scala#5032: Make sure that erroneous empty idents have a position

a0d6a55

nicolasstucki force-pushed the fix-#5032 branch from c7215a6 to a0d6a55 Compare January 20, 2019 16:06

Refactor code and check for errors in typeIdent

d362496

nicolasstucki added 2 commits January 20, 2019 17:37

Make error offset more precise

652f94e

Factor ident span computation

1cb3bdd

nicolasstucki added the stat:needs review label Jan 20, 2019

nicolasstucki assigned odersky and unassigned nicolasstucki Jan 20, 2019

odersky approved these changes Jan 23, 2019

View reviewed changes

odersky merged commit 1d2d775 into scala:master Jan 23, 2019

nicolasstucki deleted the fix-#5032 branch January 23, 2019 13:27

Provide feedback