Skip to content

Fix #5551: Handle repl line modules in splicer #5688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2019
Merged

Fix #5551: Handle repl line modules in splicer #5688

merged 1 commit into from
Jan 12, 2019

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Jan 9, 2019
liufengyun
liufengyun approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

compiler/src/dotty/tools/dotc/transform/Splicer.scala
val instance = loadModule(moduleClass)
(instance, instance.getClass)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need instance in the return? Seems it is not used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used in the last line of the method. https://github.com/lampepfl/dotty/pull/5688/files/b54e3c586d190fbb02df0e9f5b3b3c13a0c3c5cc#diff-43be0f2f8a9625bb70763569c65a6fdcR132

allanrenucci
allanrenucci reviewed Jan 10, 2019
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate why there is a need to special case for the REPL? Ideally the compiler should know nothing about the REPL. It could be a separate project

@nicolasstucki
Copy link
Contributor Author

The issue is that we want to load a macro the is not on the current classpath. The REPL does some magic with the classloader to include the output classpath in the current one. Not sure what else can be done for now.

In the future, we may be able to have the output directory in the classpath to expand macros defined in the same project. But we need to perform quite a few improvements before that can be performed in a sound way. When this happens we could simply remove the special case for the REPL.

@odersky odersky merged commit 971e89f into scala:master Jan 12, 2019
@allanrenucci allanrenucci deleted the fix-#5551 branch January 12, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci left review comments

@liufengyun liufengyun liufengyun approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasstucki @liufengyun @allanrenucci @odersky