Skip to content

Dropped ??? in arrayclass #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2015
Merged

Dropped ??? in arrayclass #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/scala/runtime/ScalaRunTime.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ object ScalaRunTime {
/** Return the class object representing an array with element class `clazz`.
*/
def arrayClass(clazz: jClass[_]): jClass[_] = {
??? // Dmitry: I want to see where this method is used to know how to fix it
// Dmitry: I want to see where this method is used to know how to fix it
// [Martin] Here's a stacktrace
// Exception in thread "main" scala.NotImplementedError: an implementation is missing
// at scala.Predef$.$qmark$qmark$qmark(Predef.scala:225)
// at scala.runtime.ScalaRunTime$.arrayClass(ScalaRunTime.scala:53)
// at scala.Array$.fill(Array.scala:281)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of scala-library do you have? I do not see any usage of arrayClass in Array.scala:281.

// at dotty.tools.dotc.core.Flags$.<init>(Flags.scala:139)
// newInstance throws an exception if the erasure is Void.TYPE. see SI-5680
if (clazz == java.lang.Void.TYPE) classOf[Array[Unit]]
else java.lang.reflect.Array.newInstance(clazz, 0).getClass
Expand Down