Improve inference of dependent function types to fix #5526 #5528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I somehow destroyed pickling (that's the failing tests), which is strange. |
|
Pickling with dependent function type is broke' right now in general, so it might not be your fault. I'll fix it soon and look at your pr afterwards |
Blaisorblade
reviewed
Dec 2, 2018
|
Superseded by #5631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to improve type inference on dependent function types. Addresses #5526.
This does not fix all related problems of inference on dependent function types (such as #4130). However, some cases like the ones in the tests now don't throw the Unspecified Error anymore.