Skip to content

Fix #5351: Warn about implicit conversions using ImplicitConverter #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

Duhemm
Copy link
Contributor

@Duhemm Duhemm commented Nov 1, 2018

As we do for implicit conversions, we now emit a warning when an
implicit conversion using ImplicitConverter is defined or used.

Fixes #5351

As we do for implicit conversions, we now emit a warning when an
implicit conversion using `ImplicitConverter` is defined or used.

Fixes scala#5351
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@odersky odersky merged commit 77dc93e into scala:master Nov 1, 2018
@allanrenucci allanrenucci deleted the fix/5351 branch November 1, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants