Skip to content

Fix LSP telemetry unique machine ID, release vscode-dotty 0.1.8 #5361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2018

Conversation

smarter
Copy link
Member

@smarter smarter commented Nov 1, 2018

No description provided.

Rename dotty.tracing.machineId to dotty.trace.machineId: this matches how
it's named in package.json (and using the wrong name means that the
machine id was not persisted across sessions)
@smarter smarter requested a review from abgruszecki November 1, 2018 00:29
@smarter
Copy link
Member Author

smarter commented Nov 1, 2018

(Releasing now to not have this problem in the wild for too long)

@smarter smarter merged commit 42cfb36 into scala:master Nov 1, 2018
@allanrenucci allanrenucci deleted the vscode-dotty-0.1.8 branch November 1, 2018 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant