Skip to content

Fix HoverTest with error #5356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix HoverTest with error #5356

wants to merge 1 commit into from

Conversation

Duhemm
Copy link
Contributor

@Duhemm Duhemm commented Oct 31, 2018

We return null in Hover when the type of the symbol is erroneous,
but we used to show an error message.

@Duhemm
Fix HoverTest with error
31e8870 
We return `null` in `Hover` when the type of the symbol is erroneous,
but we used to show an error message.
@Duhemm Duhemm requested a review from smarter October 31, 2018 17:41
@allanrenucci
Copy link
Contributor

Fixed in #5355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter Awaiting requested review from smarter

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Duhemm @allanrenucci @smarter