Error msg/stable identifiers #5334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Oct 30, 2018
| extends Message(StableIdentPatternID) { | ||
| override def kind: String = "Syntax" | ||
| override def msg: String = { | ||
| hl"""|Stable identifier required, but ${tree.show} found""" |
There was a problem hiding this comment.
Can be rewritten as hl"Stable identifier required, but $tree found"
|
I updated the error message |
nicolasstucki
suggested changes
Dec 10, 2018
compiler/src/dotty/tools/dotc/reporting/diagnostic/ErrorMessageID.java
Outdated
Show resolved
Hide resolved
|
You will also need to rebase it. |
hermesespinola
force-pushed
the
error-msg/stable-identifiers
branch
from
4484a36 to
0984da3
Compare
nicolasstucki
approved these changes
Dec 13, 2018
|
Thanks @hermesespinola |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds messages for checking stable identifiers.
Right now I'm considering this error will only show up in pattern matching, is that right?
Part of #1589