Add more detail pages for implicit/dependent functions and class Shadowing #5331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| > Why do we want to make this change to the language? | ||
|
|
||
| tbd |
There was a problem hiding this comment.
@odersky Do you have any input on that? I couldn't find anything on the motivation in history...
There was a problem hiding this comment.
Shadowing is a irregular case. We don't do that for any other kind of member. In both theory and the new compiler implementation the only way to implement it would be to invent a new mangled name for each inner class, which is really clunky.
odersky
requested changes
Oct 31, 2018
| = Si` is assumed. If the expected type of the anonymous implicit function is | ||
| some other type, all implicit parameter types must be explicitly given, and | ||
| the expected type of `e` is undefined. The type of the anonymous implicit | ||
| function is `scala.ImplicitFunctionN[S1, ...,Sn, T]`, where `T` is the packed |
There was a problem hiding this comment.
The term "packed" does not exist anymore in Scala 3. The term to use is probably something like "widened" (i.e singleton type are widened), but we'd need to define that centrally for the new spec.
| Note: The closing paragraph of the [Anonymous Functions section](https://www | ||
| .scala-lang.org/files/archive/spec/2.12/06-expressions.html#anonymous- | ||
| functions) of the Scala 2.12 is subsumed by implicit function types and should | ||
| be remove. |
|
|
||
| > Why do we want to make this change to the language? | ||
|
|
||
| tbd |
There was a problem hiding this comment.
Copy the gist of my comment in there.
OlivierBlanvillain
force-pushed
the
sips-olivier
branch
from
79db7ab to
1d07a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.