Add regression tests for #1593 #5291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Oct 18, 2018
There was a problem hiding this comment.
It's good that these tests pass but the underlying issue is still here: we call "isRef AnyClass" in several places assuming this means that the type is Any, but it also returns true for refinements of Any. I think Martin's comments in that PR are correct and we should have a separate stricter version of isRef (with a different name) that we use everywhere we check "isRef AnyClass" or "isRef ObjectClass"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests from the PR #1593. These tests currently pass and we could close that PR.