Skip to content

Resugar Varargs #5273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2018
Merged

Resugar Varargs #5273

merged 2 commits into from
Oct 18, 2018

Conversation

tuvior
Copy link

@tuvior tuvior commented Oct 17, 2018

Function Declaration:

  • type of parameter resugared from Seq[T] @scala.annotation.internal.Repeated() to T*

Function Call:

  • when necessary explicity type parameter as _*

Tobias Bordenca added 2 commits October 17, 2018 12:34
Resugar varargs scala#4526
02967c9 
Remove annotation from function declaration

Explicitly type non sequence literal arguments as varargs in function call (_*)
Add tests for varargs and put in whitelist
e94f0ef
dottybot
dottybot reviewed Oct 17, 2018
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@nicolasstucki nicolasstucki merged commit ae7af82 into scala:master Oct 18, 2018
@tuvior tuvior deleted the decompiler-varargs branch November 29, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuvior @nicolasstucki @dottybot