Skip to content

Fix #5247: Support type blocks and fix generic tuples #5261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2018

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Oct 16, 2018

Type block are represented with Block nodes where all statements
are TypeDefs and the expression is a TypeTree.

{
  type T1 = ...
  ...
  type Tn = ...
  T // Where T refers to T1, ..., Tn
}

We already had them but they were not properly handled.

@nicolasstucki nicolasstucki self-assigned this Oct 16, 2018
@nicolasstucki nicolasstucki changed the title Fix #5247: Support type blocks Fix #5247: Support type blocks and fix generic tuples Oct 16, 2018
@nicolasstucki nicolasstucki removed their assignment Oct 16, 2018
@nicolasstucki nicolasstucki requested a review from odersky October 16, 2018 13:10
Type block are represented with `Block` nodes where all statements
are `TypeDef`s and the expression is a `TypeTree`.
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@odersky odersky assigned nicolasstucki and unassigned odersky Oct 20, 2018
@nicolasstucki nicolasstucki merged commit f758994 into scala:master Oct 20, 2018
@nicolasstucki nicolasstucki deleted the fix-#5247 branch October 20, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants