Create infrastructure for SemanticDB #5193
Conversation
|
I plan to refactor common logic with the decompiler later on. |
| import dotty.tools.dotc.core.Phases.Phase | ||
| import dotty.tools.dotc.tastyreflect.TastyImpl | ||
|
|
||
| class TASTyConsumer extends Phase { |
| override def setup(args0: Array[String], rootCtx: Context): (List[String], Context) = { | ||
| var args = args0.filter(a => a != "-gen-semantic-db") | ||
| if (!args.contains("-from-tasty")) args = "-from-tasty" +: args | ||
| if (args.contains("-d")) args = "-color:never" +: args |
There was a problem hiding this comment.
Copy pasted from the decompiler. Will remove it.
|
What about a compiler plugin instead? |
|
A subproject in the dotty repo is better for rapid development (if something needs to be fixed in tasty reflect while working on the emitter) but eventually it should be in a separate repo yes (and it shouldn't need to be a compiler plugin since it shouldn't have to use internal compiler APIs) |
nicolasstucki
force-pushed
the
semanticdb-infrastructure
branch
3 times, most recently
from
b3a94b1 to
941f95d
Compare
There was a problem hiding this comment.
Cool! Please ping me if you have any questions. It's possible to generate pure Java bindings for semanticdb, I haven't tried it myself but there are instructions here https://github.com/thesamet/sbt-protoc#installation
project/Build.scala
Outdated
| @@ -677,6 +677,7 @@ object Build { | |||
| val dottyCompiler = jars("dotty-compiler") | |||
| val args0: List[String] = spaceDelimited("<arg>").parsed.toList | |||
| val decompile = args0.contains("-decompile") | |||
| val consumeTasty = args0.contains("-gen-semantic-db") | |||
There was a problem hiding this comment.
nit: I'd write -gen-semanticdb and in in camel case it would be GenSemanticdb (or SemanticdbGen, ..)
There was a problem hiding this comment.
Actually I should remove this flag.
tests/run-with-compiler/tasty-consumer/Test.scala shows an example of how to consume tasty files.
nicolasstucki
force-pushed
the
semanticdb-infrastructure
branch
from
941f95d to
d90e8c3
Compare
nicolasstucki
force-pushed
the
semanticdb-infrastructure
branch
from
b52292e to
7ba35b6
Compare
nicolasstucki
changed the title
|
@smarter can we merge this? |
|
I agree with the names. They are horrible. Any suggestions? |
|
no idea |
|
I will ask around to see if someone has a good idea |
No description provided.