IDE: Fix crash on malformed input #5151
Merged
+34
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting a dotty position into an lsp4j position, we need to carefully handle NoPosition to avoid assertion errors on methods like Position#start. To be safe, this commit now always checks if Position#exists is true before doing the conversion. This fixes a crash demonstrated by the added test.
allanrenucci
approved these changes
Sep 24, 2018
|
In general, it's hard to know if we're missing a position because of a bug or because the input is just very weird. It seems best to not assume too much and be conservative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a dotty position into an lsp4j position, we need to
carefully handle NoPosition to avoid assertion errors on methods like
Position#start. To be safe, this commit now always checks if
Position#exists is true before doing the conversion. This fixes a crash
demonstrated by the added test.