Fix #5116: make it easy to sequentially run test #5120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, it suffices to use `1` to make all tests sequential:
val pool = threadLimit match {
case Some(i) => JExecutors.newWorkStealingPool(1)
case None => JExecutors.newWorkStealingPool(1)
}
Previously, `1` doesn't work because the progress bar monopolizes one thread
in the thread pool.
allanrenucci
suggested changes
Sep 19, 2018
| /** A single `Runnable` that prints a progress bar for the curent `Test` */ | ||
| private def createProgressMonitor: Runnable = () => { | ||
| /** A `TimerTask` that prints a progress bar for the curent `Test` */ | ||
| private def updateProgressMonitor: Unit = { |
There was a problem hiding this comment.
Side effectful, so def updateProgressMonitor()
| @@ -479,6 +484,10 @@ trait ParallelTesting extends RunnerOrchestration { self => | |||
| throw new TimeoutException("Compiling targets timed out") | |||
| } | |||
|
|
|||
| // wait for the timer task to execute once | |||
| Thread.sleep(300) | |||
There was a problem hiding this comment.
I would just call updateProgressMonitor() and not wait
There was a problem hiding this comment.
Also, it should probably go after eventualResults.foreach(_.get)
| @@ -481,6 +486,10 @@ trait ParallelTesting extends RunnerOrchestration { self => | |||
|
|
|||
| eventualResults.foreach(_.get) | |||
|
|
|||
| // update progress one last time | |||
| updateProgressMonitor() | |||
There was a problem hiding this comment.
I would cancel the timer first to make sure there is no concurrent call to updateProgressMonitor.
Also it should only be called if isInteractive && !suppressAllOutput is true. I suggest something like:
val logProgress = isInteractive && !suppressAllOutput
if (logProgress) {
val task = new TimerTask {
def run() = updateProgressMonitor()
}
timer.schedule(task, 100, 200)
}
...
if (logProgress) {
timer.cancel()
// update progress one last time
updateProgressMonitor()
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5116: make it easy to sequentially run test
With this change, it suffices to use
1to make all tests sequential:Previously,
1doesn't work because the progress bar monopolizes one threadin the thread pool.