Fix #4951: Increase stack size before bootstrap to reduce tests flakyness #4992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
approved these changes
Aug 23, 2018
project/Build.scala
Outdated
| @@ -718,6 +718,9 @@ object Build { | |||
| TestFrameworks.JUnit, | |||
| "--exclude-categories=dotty.BootstrappedOnlyTests", | |||
| ), | |||
| // increase stack size for non-bootstrapped compiler, because some code | |||
| // is only tail-recursive after bootstrap | |||
| javaOptions += "-Xss2m" | |||
To test, use `testCompilation inductive-implicits-bench` before and after, locally.
Blaisorblade
force-pushed
the
more-stack
branch
from
6abc212 to
910ee8a
Compare
|
Comments addressed (and tested), mergeable when CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test, use
testCompilation inductive-implicits-benchbefore and after,locally. I get a failure before and a pass after.
We consume more stack before bootstrap because many typer methods are only tail-recursive if
trackor such are inlined (via@forceInline), and we don't plan to fix that. Viceversa, if this test stack overflows after bootstrap, we probably want to take a look.