Fix JLine dependencies #4983
Merged
Fix JLine dependencies #4983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also need to change the dotc script: https://github.com/lampepfl/dotty/blob/master/dist/bin/common#L122-L124 |
jline-$VERSION.jar is a bundle that contains the content of jline-terminal-$VERSION.jar and other modules. jline-terminal-jna depends on jline-terminal. This means that the Dotty build depends on both jline and jline-terminal and classfiles may be read from either jar (dependencies on the classpath are usually not in a stable order). They should be identical so it's not a big problem, but it breaks Zinc incremental compilation. This commit fixes this by not using the jline bundle jar anymore.
smarter
force-pushed
the
fix-jline-deps
branch
from
cbadf30 to
5553862
Compare
|
@liufengyun Thanks for the info, done. |
allanrenucci
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jline-$VERSION.jar is a bundle that contains the content of
jline-terminal-$VERSION.jar and other modules. jline-terminal-jna
depends on jline-terminal. This means that the Dotty build depends on
both jline and jline-terminal and classfiles may be read from either
jar (dependencies on the classpath are usually not in a stable order).
They should be identical so it's not a big problem, but it breaks Zinc
incremental compilation. This commit fixes this by not using the jline
bundle jar anymore.