Fix Tasty reflect with varargs in unapply #4877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-tasty-reflect-literal-seq-unapply
branch
from
98a03ea to
5e352e7
Compare
liufengyun
reviewed
Jul 31, 2018
| case _ => None | ||
| } | ||
| private def effectivePatterns(patterns: List[Pattern]): List[Pattern] = patterns match { | ||
| case patterns0 :+ Trees.SeqLiteral(elems, _) => patterns0 ::: elems | ||
| case _ => patterns |
There was a problem hiding this comment.
Is it possible that patterns only contain SeqLiteral?
There was a problem hiding this comment.
Only the last one can one can have the SeqLiteral as only the last argument can be a varargs.
There was a problem hiding this comment.
- It's nice to have a link to test case here, as it's really difficult to figure out the test case
- The code fails to handle the following case:
case class D(b: B[_]*)
class Test {
def f2(d: D) = d match {
case D(a, b1, b2) => ()
}
}
liufengyun
reviewed
Jul 31, 2018
| case _ => None | ||
| } | ||
| private def effectivePatterns(patterns: List[Pattern]): List[Pattern] = patterns match { | ||
| case patterns0 :+ Trees.SeqLiteral(elems, _) => patterns0 ::: elems | ||
| case _ => patterns |
There was a problem hiding this comment.
- It's nice to have a link to test case here, as it's really difficult to figure out the test case
- The code fails to handle the following case:
case class D(b: B[_]*)
class Test {
def f2(d: D) = d match {
case D(a, b1, b2) => ()
}
}
nicolasstucki
force-pushed
the
fix-tasty-reflect-literal-seq-unapply
branch
from
c0edcb6 to
457b554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.