Add some post conditions to ReifyQuotes #4870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-postcondition-in-reify-quotes
branch
from
fae2b09 to
60e22f8
Compare
| @@ -74,6 +74,21 @@ class ReifyQuotes extends MacroTransformWithImplicits { | |||
|
|
|||
| override def phaseName: String = "reifyQuotes" | |||
|
|
|||
| override def checkPostCondition(tree: Tree)(implicit ctx: Context): Unit = { | |||
| if (ctx.owner.ownersIterator.exists(_.isTransparentMethod)) { | |||
There was a problem hiding this comment.
Does it make sense to do these tests if ctx.compilationUnit.containsQuotesOrSplices is false?
There was a problem hiding this comment.
Yes, some other phase could inset by mistake one of those calls.
| // assert(tree.symbol != defn.QuotedType_~) // TODO widen ~ type references at stage 0? | ||
| assert(tree.symbol != defn.QuotedExpr_apply) | ||
| assert(tree.symbol != defn.QuotedType_apply) | ||
| } |
There was a problem hiding this comment.
Could this be rewritten as?
tree match {
case tree: RefTree if !ctx.inTransparentMethod =>
assert(!tree.symbol.isQuote)
// assert(!tree.symbol.isSplice) // TODO widen ~ type references at stage 0?
assert(tree.symbol != defn.QuotedExpr_~)
case tree: Select if tree.symbol == defn.QuotedExpr_~ =>
assert(Splicer.canBeSpliced(tree.qualifier))
case _ =>
}ctx.inTransparentMethod is more expensive than a type test
nicolasstucki
force-pushed
the
add-postcondition-in-reify-quotes
branch
from
4ef1bf7 to
c0e1279
Compare
allanrenucci
approved these changes
Jul 31, 2018
| override def checkPostCondition(tree: Tree)(implicit ctx: Context): Unit = { | ||
| val inTransparentMethod = ctx.owner.ownersIterator.exists(_.isTransparentMethod) | ||
| tree match { | ||
| case tree: RefTree if !inTransparentMethod => |
There was a problem hiding this comment.
Why not use ctx.inTransparentMethod here?
There was a problem hiding this comment.
No reason. I will change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.