Simplify InterceptedMethods. Fix #439 #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } /* else if (isPrimitiveValueClass(qual.tpe.typeSymbol)) { | ||
| lazy val Select(qual, _) = tree.fun | ||
| val Any_## = this.Any_## | ||
| val Any_!= = this.Any_!= |
There was a problem hiding this comment.
Why not:
val Any_## = defn.Any_##
val Any_!= = defn.Any_!=
|
The documentation for the class says:
But this is no longer the case, this comment needs to be updated. |
|
I wonder if |
DarkDimius
force-pushed
the
interceptedM
branch
from
0897d90 to
525d062
Compare
|
It could. But I would better leave it as is. We do not need full overload resolution(which could be resource-intensive) |
DarkDimius
force-pushed
the
interceptedM
branch
from
525d062 to
f36e452
Compare
| * - `x == y` for == in class Any becomes `x equals y` with equals in class Object. | ||
| * - `x != y` for != in class Any becomes `!(x equals y)` with equals in class Object. | ||
| * - `x.##` for ## in other classes becomes calls to ScalaRunTime.hash, | ||
| * - `x != y` for != in class Any becomes `!(x != y)` with != in class Any. |
There was a problem hiding this comment.
Typo, should be !(x == y) with == in ...
There was a problem hiding this comment.
yes. Thanks for noticing.
I'd better go and have some rest.
DarkDimius
force-pushed
the
interceptedM
branch
from
f36e452 to
afaec82
Compare
|
LGTM |
DarkDimius
added a commit
that referenced
this pull request
Apr 16, 2015
Simplify InterceptedMethods. Fix #439
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now a single pattern-match, instead of series of nested ifs.
review by @smarter