Upgrade IDE dependencies, release vscode-dotty 0.1.5 #4828
Conversation
smarter
force-pushed
the
release/vscode-dotty-0.1.5
branch
from
cbf2209 to
030a2f8
Compare
There was a problem hiding this comment.
I'll defer to @Duhemm for the code that has to do with rendering and testing the comments in the IDE
| markup.setValue( | ||
| s"""```scala | ||
| |$typeInfo | ||
| |$docMarkup```""".stripMargin.stripLineEnd) |
There was a problem hiding this comment.
Why stripLineEnd? Also shouldn't the ``` be on a new line?
| else { | ||
| val symbol = Interactive.enclosingSourceSymbol(trees, pos) | ||
| val docComment = ctx.docCtx.flatMap(_.docstring(symbol)) | ||
| val markedStrings = docMarkedStrings(docComment, tpw.show.toString) | ||
| new Hover(markedStrings.map(JEither.forRight(_)).asJava, null) | ||
| val content = hoverContent(tpw.show.toString, docComment) |
There was a problem hiding this comment.
toString redundant after show?
On the server side, uses of lsp4j.MarkedString were replaced by lsp4j.MarkupContent since the former is deprecated (and seems to cause some rendering bugs with the updated dependencies).
smarter
force-pushed
the
release/vscode-dotty-0.1.5
branch
from
030a2f8 to
e626618
Compare
| s"""```scala | ||
| |$typeInfo | ||
| |$comment | ||
| |```""" |
There was a problem hiding this comment.
There used to be a thin line that separated the type info from the comment. It would be nice to re-introduce it, since it makes the hover information easier to read:
case Some(comment) =>
s"""```scala
|$typeInfo
|```
|---
|```scala
|$comment
|```"""There was a problem hiding this comment.
I tried that but that's not equivalent to the thin line we had before: it adds a really thick line which I find distracting
There was a problem hiding this comment.
There's an issue for this: microsoft/language-server-protocol#518
|
I'm going to merge this, however I won't release 0.1.5 until the next Dotty release: it looks like recent version of vscode-languageclient do not agree with LSP4J on how to read the content of MarkedString in hover responses, the result is that when using vscode-dotty 0.1.5 with Dotty 0.9.0-RC1, the hover messages just displays |
On the server side, uses of lsp4j.MarkedString were replaced by
lsp4j.MarkupContent since the former is deprecated (and seems to cause
some rendering bugs with the updated dependencies).