repl: don't blink the opening paren after typing a closing paren #4761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
approved these changes
Jul 4, 2018
| .variable(SECONDARY_PROMPT_PATTERN, "%M") // A short word explaining what is "missing", | ||
| // this is supplied from the EOFError.getMissing() method | ||
| .variable(LIST_MAX, 400) // Ask user when number of completions exceed this limit (default is 100). | ||
| .variable(BLINK_MATCHING_PAREN, 0) // Don't blink the opening paren after typing a closing paren. |
There was a problem hiding this comment.
Looking at the implementation, it should be a Long
|
Why? Just tried this out, looks potentially useful to me. |
|
I find it distracting, it's also a change from the existing behavior. We may want to expose the JLine configuration variables in a configuration file somewhere to let people customize whatever they want. |
|
A better solution I think would be to do what text editors usually do and highlight both parens when the cursor is on one of the paren, we should be able to do that based on the information we have after parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.