Print val for class parameters
#4705
Conversation
| } | ||
| case _ => | ||
| } | ||
|
|
There was a problem hiding this comment.
Rename printArgDef to printParam? My impression is that param is used at definition site, arg is used usually used at calling site.
| body.collectFirst { | ||
| case vdef @ ValDef(`name`, _, _) if vdef.flags.isParamAccessor => | ||
| if (!vdef.flags.isLocal && !vdef.flags.isCaseAcessor) | ||
| this += "val " // TODO `var`s |
There was a problem hiding this comment.
More todos: access modifiers, default parameters, implicits.
nicolasstucki
dismissed
liufengyun’s stale review
Add more code that needs review
|
@liufengyun could you review the second commit |
| printedPrefix | ||
| } | ||
|
|
||
| def printFullClassName(tp: TypeOrBounds): Unit = { |
There was a problem hiding this comment.
TypeOrBounds -> Type? The same for the next line.
There was a problem hiding this comment.
No, it is TypeOrBounds or more precisely Type | NoPrefix which is encoded as TypeOrBounds for scala2 compat
| printedPrefix |= printProtectedOrPrivate(vdef) | ||
| if (vdef.flags.isMutable) this += "var " | ||
| else if (!printedPrefix && vdef.flags.isCaseAcessor) this // val not explicitly needed | ||
| else this += "val " |
There was a problem hiding this comment.
I would negate the second else if and put this += "val " as the body.
There was a problem hiding this comment.
The name printedPrefix is not informative enough to understand the logic here.
| var printedPrefix = false | ||
| if (vdef.flags.isOverride) { | ||
| this += "override " | ||
| printedPrefix = true |
There was a problem hiding this comment.
Why skip val (line 641) if we have override?
There was a problem hiding this comment.
We skip val if we have NOT override
nicolasstucki
force-pushed
the
decompiled-print-constructor-vals
branch
from
5c48dfc to
a62585c
Compare
No description provided.