Print decompiled refinements #4698
Conversation
| @@ -74,6 +74,7 @@ class ShowSourceCode[T <: Tasty with Singleton](tasty0: T) extends Show[T](tasty | |||
|
|
|||
| if (flags.isObject) this += "object " += name.stripSuffix("$") | |||
| else if (flags.isTrait) this += "trait " += name | |||
| else if (flags.isAbstract) this += "abstract class " += name | |||
| else this += "class " += name | |||
There was a problem hiding this comment.
sealed, final and access modifiers are missing here.
There was a problem hiding this comment.
final is a few lines above. I will add sealed .
| if (!sym.flags.isLocal) { | ||
| printType(prefix) | ||
| this += "." | ||
| } |
There was a problem hiding this comment.
It seems it is also OK to print the prefix here? For hygiene, we do need to print the prefix for local members as well.
There was a problem hiding this comment.
This is to not print prefixes in references inside the parents of a class.
There was a problem hiding this comment.
Could you please explain what do you mean by prefixes in references inside the parents of a class? I see in the code C.this.T becomes T, which may be unhygienic.
There was a problem hiding this comment.
I will reprint the prefix and add test cases where this fails
| this += ": " | ||
| printType(tp) | ||
| } | ||
| printMethodicType(info) |
There was a problem hiding this comment.
I'd refactor the case Refinement into a method, as it's too fat.
It seems to be neater if printMethodicType is only called from the first case of patmat on info.
There was a problem hiding this comment.
Will refactor
| printMethodicTypeParams(paramNames, params) | ||
| this += ") => " | ||
| printTypeOrBound(body) | ||
|
|
There was a problem hiding this comment.
Why is this necessary? I assume method types are handled already in refinement case.
There was a problem hiding this comment.
As far as I can see we do not need it. I will remove it.
No description provided.