Skip to content

Print this id and filter object lazy val #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@@ -317,6 +323,7 @@ class ShowSourceCode[T <: Tasty with Singleton](tasty0: T) extends Show[T](tasty
case Term.Block(stats0, expr) =>
def isLoopEntryPoint(tree: Tree): Boolean = tree match {
case Term.Apply(Term.Ident("while$" | "doWhile$"), _) => true
case tree @ ValDef(_, _, _) => tree.flags.isObject
case _ => false
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name isLoopEntryPoint and the change don't align.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nicolasstucki nicolasstucki force-pushed the fix-objects-in-stats branch 3 times, most recently from 20f3e77 to 071431c Compare June 21, 2018 13:47
@nicolasstucki nicolasstucki force-pushed the fix-objects-in-stats branch from 071431c to 53ce976 Compare June 21, 2018 14:22
@nicolasstucki nicolasstucki merged commit 90904e8 into scala:master Jun 21, 2018
@Blaisorblade Blaisorblade deleted the fix-objects-in-stats branch June 21, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants