Skip to content

Print self types #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2018
Merged

Print self types #4696

merged 3 commits into from
Jun 21, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if (stats1.nonEmpty) printBody(printSelf = false)
case Some(ValDef(_, _, _)) => printBody(printSelf = true)
case _ => if (stats1.nonEmpty) printBody(printSelf = false)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, I would start a new line for all case bodies.

@nicolasstucki nicolasstucki merged commit 9d73a09 into scala:master Jun 21, 2018
@Blaisorblade Blaisorblade deleted the print-self-types branch June 21, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants