Add stylechecking to test suite, fix style errors #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotty uses returns, nulls, and has methods with huge cyclomatic compexity
In Dotty we frequently want to make method look like it returns a constructor, when it's actually not.
Commonly used in dotty syntax isn't respected by scalastyle: ``` if (...) bar else if (...) foo else foo ```
We use structural types in return values, sometimes we override equals without overriding hashcode
…e counterexample. TreeUnpickler: 494, rewriting to reduce/fold isn't equivalent. !exists(false) isn't easier to read.
|
@odersky please review. |
|
LGTM! On Thu, Apr 9, 2015 at 6:20 PM, Dmitry Petrashko notifications@github.com
Martin Odersky |
DarkDimius
added a commit
that referenced
this pull request
Apr 9, 2015
Add stylechecking to test suite, fix style errors
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 12, 2015
Add stylechecking to test suite, fix style errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had huge amount of trailing whitespaces in ends of lines,
huge amount of files not ending in new line,
absence of spaces around + in many files,
and several dozens of tabs and missing spaces after ifs.