Print double breaks after statements to avoid ambiguity #4689
Conversation
nicolasstucki
force-pushed
the
add-colon-to-statement
branch
from
80be1cc to
63421c4
Compare
| this += ";" | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we add a blank line instead of ;?
Also, it seems it's only needed if the previous tree may cause ambiguity. This can be an improvement.
There was a problem hiding this comment.
It can be implemented but it would require knowing which is the next tree is printed and how it will be printed. This solution is much simpler, homogenous and less bug-prone. I will try to remove them in the future once I have a complete test suite.
Using by default an additional blank line add too many lines. I would consider if we only print it when needed.
There was a problem hiding this comment.
Should we add ; all the time? Looking at the diff, I find it a bit weird that sometime a statement ends with ; and sometime not
There was a problem hiding this comment.
I added it at the end of all statements. The expression at the end of the block does not need it. Look at it as a separator.
Still later I will work on making the format nicer to look at. For now the main goal is corecness.
There was a problem hiding this comment.
I think we should add a blank line instead. Writing semicolons is just so weird when looking at Scala code. I believe there is an easy way to add blank lines: When you print a statement sequence, add blank line in front of every Block node, except if it is the first statement.
nicolasstucki
force-pushed
the
add-colon-to-statement
branch
2 times, most recently
from
c91c182 to
57b9a51
Compare
nicolasstucki
changed the title
; at the end of statements to avoid ambiguity
nicolasstucki
force-pushed
the
add-colon-to-statement
branch
from
57b9a51 to
daea935
Compare
nicolasstucki
dismissed stale reviews from odersky and liufengyun
Changed to line breaks
|
@liufengyun could you re-review this PR |
For example, the first snippet is `foo.apply(...)` and the second is
eval `foo` and then eval the block.
```scala
foo
{
...
}
```
```scala
foo
{
...
}
```
nicolasstucki
force-pushed
the
add-colon-to-statement
branch
from
daea935 to
d5d991d
Compare
For example, the first snippet is
foo.apply(...)and the second iseval
fooand then eval the block.foo { ... }foo; { ... }