Fix printing parents in decompiler #4686
Merged
+60
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-decompiling-parents
branch
from
3a1418e to
3b39530
Compare
liufengyun
approved these changes
Jun 19, 2018
| } | ||
|
|
||
| def printSeparated(list: List[Parent]): Unit = list match { | ||
| case Nil => |
There was a problem hiding this comment.
unreachable case, throw an exception here if reached?
There was a problem hiding this comment.
I moved the nonEmpty check, now this is reachable.
* Fixed multiple argument list constructors * Added missing `with` in between the parents
nicolasstucki
force-pushed
the
fix-decompiling-parents
branch
from
3b39530 to
057b061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
within between the parents