Fix #4674: Do not emit waring if types are the same #4684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I would say the warning is legitimate |
|
Maybe I should improve the warning message instead. |
| val msg = s"The highlighted type test will always succeed since the scrutinee type ($foundCls) is a subtype of ${testCls}" | ||
| val msg = | ||
| if (foundCls != testCls) s"The highlighted type test will always succeed since the scrutinee type ($foundCls) is a subtype of $testCls" | ||
| else s"The highlighted type test has the same type ($foundCls) as the scrutinee" |
There was a problem hiding this comment.
I don't understand the message. Did you mean something like
The highlighted type test will always succeed since the scrutinee type ($foundCls) is the same as the tested type
There was a problem hiding this comment.
Yes, I will change it to make it clearer.
allanrenucci
approved these changes
Jun 19, 2018
| val msg = s"The highlighted type test will always succeed since the scrutinee type ($foundCls) is a subtype of ${testCls}" | ||
| val msg = | ||
| if (foundCls != testCls) s"The highlighted type test will always succeed since the scrutinee type ($foundCls) is a subtype of $testCls" | ||
| else s"The highlighted type test will always succeed since the scrutinee type ($foundCls) is the same as the tested type" |
There was a problem hiding this comment.
nitpick:
val msg = {
val addendum =
if (foundCls != testCls) s" is a subtype of $testCls"
else " is the same as the tested type"
s"The highlighted type test will always succeed since the scrutinee type ($foundCls)" + addendum
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.