Fix case class decompilation #4633
Conversation
nicolasstucki
force-pushed
the
fix-case-class-decompilation
branch
3 times, most recently
from
d6f0dd3 to
820c3d8
Compare
nicolasstucki
force-pushed
the
fix-case-class-decompilation
branch
from
820c3d8 to
f84d017
Compare
| tp match { | ||
| case Type.SymRef(cdef @ ClassDef(_, _, _, _, _), _) if !cdef.flags.isObject => this += ".this" | ||
| case _ => this | ||
| } |
There was a problem hiding this comment.
Could you explain why special case object here?
There was a problem hiding this comment.
When refering to the this type of a module we just refere directly to the module itself. For example scala.Predef and not scala.Predef.this.
| @@ -112,8 +112,24 @@ class ShowSourceCode[T <: Tasty with Singleton](tasty0: T) extends Show[T](tasty | |||
| } | |||
| } | |||
|
|
|||
| def keepDefinition(d: Definition): Boolean = { | |||
| val flags = d.flags | |||
| import flags._ | |||
There was a problem hiding this comment.
I think import flags._ doesn't help in terms of readability: it takes me some time to realize that isParam is a method on d.flags. In isCaseUnOverridableMethod, it still uses d.flags.
A short doc can help better understand the motivation for the method isCaseUnOverridableMethod. A naive question: why not just ignore all synthetic definitions?
There was a problem hiding this comment.
Will improve code and add docs.
I decided to print the synthetic methods to allow users to see what was generated. I will add some /* synthetic */ comment on them later. And I'm considering adding a mode that those not print them. I started printing them because I can test more code, therefore more of the Tasty reflect API.
No description provided.