Add While and DoWhile extractors Tasty reflect #4630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-while-to-tasty-relect
branch
from
12842bf to
948c6ea
Compare
|
Rebased |
nicolasstucki
force-pushed
the
add-while-to-tasty-relect
branch
from
948c6ea to
0812693
Compare
|
Rebased |
nicolasstucki
force-pushed
the
add-while-to-tasty-relect
branch
from
0812693 to
599ee65
Compare
|
Rebased |
allanrenucci
approved these changes
Jun 22, 2018
| case _ => None | ||
| } | ||
| private def normalizedLoops(tree: tpd.Tree)(implicit ctx: Context): tpd.Tree = tree match { | ||
| case block: tpd.Block => |
There was a problem hiding this comment.
Could be case block: tpd.Block if block.stats.size > 1 =>
| case Trees.Block(stats, expr) => Some((stats, expr)) | ||
| case _ => None | ||
| } | ||
| private def normalizedLoops(tree: tpd.Tree)(implicit ctx: Context): tpd.Tree = tree match { |
There was a problem hiding this comment.
This needs a comment. It is not clear at all what it does
nicolasstucki
force-pushed
the
add-while-to-tasty-relect
branch
from
599ee65 to
d143026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.