More changes to protected accessors #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Allan, I did some improvements to the protected accessor scheme. Can you use this one as a basis for the partial functions PR? |
Several fixes detected during refactorings of inliner
Use
inline$x
inline$x_=
protected$x
protected$x_=
instead of
inline_get$x
inline_set$x
protected_get$x
protected_set$x
Advantage: more idiomatic, and it's possible to make this work
on untyped trees as well.
The old scheme would have required accessors for every operator assignment
when extending it to untyped trees.
|
Rebased on top of master which now contains #4597 |
allanrenucci
approved these changes
May 31, 2018
| private def rewire(reference: RefTree, accessor: Symbol)(implicit ctx: Context): Tree = { | ||
| reference match { | ||
| case Select(qual, _) => qual.select(accessor) | ||
| case Ident(name) => ref(accessor) |
There was a problem hiding this comment.
Do you need to desugar the Identifier here like in tpd.becomes?
There was a problem hiding this comment.
No, since we always to refer to given accessor.
| val sym = ctx.newSymbol(owner, name, Synthetic | Method, info, coord = pos).entered | ||
| if (sym.allOverriddenSymbols.exists(!_.is(Deferred))) sym.setFlag(Override) | ||
| sym | ||
| } | ||
|
|
||
| /** An accessor symbol, create a fresh one unless one exists already */ | ||
| private def accessorSymbol(owner: Symbol, accessorName: TermName, accessorInfo: Type, accessed: Symbol)(implicit ctx: Context) = { | ||
| def refersToAccessed(sym: Symbol) = accessedBy.get(sym) == Some(accessed) |
There was a problem hiding this comment.
accessedBy.get(sym).contains(accessed)?
There was a problem hiding this comment.
Ah, yes. I'll roll that into another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes in the AccessProxies scheme that were discovered when revising the inliner.