Skip to content

Re-enable collection-strawman tests #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Re-enable collection-strawman tests #4596

wants to merge 1 commit into from

Conversation

allanrenucci
Copy link
Contributor

@allanrenucci allanrenucci commented May 29, 2018 •
edited
Loading

Blocked on #4590

@Blaisorblade
Copy link
Contributor

The failing test is for a dormant feature, but it covers a compilation path that we care for and isn't tested otherwise on collection-strawman, so we should add a test.

In particular, failing test LinkTests relies on -Xlink, which we don't really support (it's part of dotty-linker). But the failure could be due to loading collections-strawman from Tasty: to confirm this, we should extend FromTastyTests to apply to collections-strawman.

@allanrenucci allanrenucci self-assigned this Jun 26, 2018
@allanrenucci
Copy link
Contributor Author

Closing in favor of #4724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@allanrenucci allanrenucci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allanrenucci @Blaisorblade