Enable -Ycheck:all in Dotty Doc tests
#4575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| relevantSyms.foreach { sym => | ||
| expandParentDocs(sym) | ||
| val usecases = docbase.docstring(sym).map(_.usecases).getOrElse(Nil) | ||
|
|
||
| usecases.foreach { usecase => | ||
| enterSymbol(createSymbol(usecase.untpdCode)) | ||
| val createdSymbol = enterSymbol(createSymbol(usecase.untpdCode)) | ||
| createdSymbol.setFlag(Flags.DocArtifact) |
There was a problem hiding this comment.
Can you avoid creating a new flag and use the symbol name instead (i.e. is the name a DocArtifactName)?
There was a problem hiding this comment.
I didn't know about name.is, thanks!
Duhemm
force-pushed
the
fix/dottydoc-ycheck
branch
from
40acf8c to
d4e547c
Compare
We used to put the position of the doc artifact symbols inside their names, which created a name that is not JVM-compatible. This commit uses the fresh name creators to generate a fresh name for every symbol introduced by the documentation. The name is a fresh name composed of the name of the symbol that owns the documentation, suffixed by `$doc`.
Doc comments that have already been cooked don't need to be cooked again, and shouldn't be cooked again, because this would introduce duplicate symbols.
Duhemm
force-pushed
the
fix/dottydoc-ycheck
branch
from
d4e547c to
639018f
Compare
allanrenucci
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.