Fix #453, patternMatcher should use == #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix seems to unveil some other bug: now tree suceeds to pass Ycheck after PatMat, but fails after resolveSuper: DefDef that defines |
|
Morale of the story: Alway, always test with -Yno-double-bindings. Not doing so will most likely leave you puzzled. -Yno-double-bindings was dropped when "twice" was removed, that's why the error was not observed directly and then caused a weird failure in TreeChecker. I'll do a separate PR that makes -Yno-double-bindings the default option for testing. |
This aligns with the "-" instead of CamelCase convention for the other command line options. Also, enable -Yno-double-bindings for dotc_core.
Also, added comments to the tpd select methods that explain how the data race could arise and how to avoid it.
|
Rebased to master |
|
LGTM |
|
@odersky, thanks for investigating. |
DarkDimius
added a commit
that referenced
this pull request
Apr 9, 2015
Fix #453, patternMatcher should use ==
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.