Skip to content

Fix #4542: Enable Dotty LSP on .scala files only #4556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2018

Conversation

Duhemm
Copy link
Contributor

@Duhemm Duhemm commented May 22, 2018

Previously, the Dotty language server would try to provide services for
all .scala and .sbt files, because both are associated to the Scala
language . The association from filename to language is provided by the
extension daltonjorge.scala, which associates all .scala and .sbt
files to the Scala language.

This commit explicitly states that the Dotty LSP should only be used for
.scala files only.

Fixes #4542.

Previously, the Dotty language server would try to provide services for
all `.scala` and `.sbt` files, because both are associated to the Scala
language . The association from filename to language is provided by the
extension `daltonjorge.scala`, which associates all `.scala` and `.sbt`
files to the Scala language.

This commit explicitly states that the Dotty LSP should only be used for
`.scala` files only.

Fixes scala#4542.
@Duhemm Duhemm requested a review from Blaisorblade May 22, 2018 09:17
@smarter smarter merged commit 2224077 into scala:master May 22, 2018
@smarter
Copy link
Member

smarter commented May 22, 2018

@nicolasstucki This is probably the missing place where you need to add .tasty/.hasTasty.

@allanrenucci allanrenucci deleted the fix/issue-4542 branch May 22, 2018 12:18
@nicolasstucki
Copy link
Contributor

I will try it. Thanks.

@nicolasstucki
Copy link
Contributor

That did not help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants