Fix #4540: Add hint of probable source of issue #4554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
May 22, 2018
| throw new StopInterpretation(msg, pos) | ||
| } | ||
| } | ||
|
|
||
| private def extraMsg = "(the most common reason for that is that you cannot use inline macro implementations in the same compilation run that defines them)" |
There was a problem hiding this comment.
Maybe make this sentence shorter as it is in parenthesis. Or make it a separate sentence.
Something like "You defined and used macros in the same compilation run?"
There was a problem hiding this comment.
Splitted into two sentences
There was a problem hiding this comment.
I will keep this text as it is the same as for scala 2 macros andif they seach for it they might still get some useful insight on why they need to be in different compilation units.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.