Skip to content

Micro-optimize SymbolLoader#complete #4508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2018
Merged

Micro-optimize SymbolLoader#complete #4508

merged 1 commit into from
May 11, 2018

Conversation

smarter
Copy link
Member

@smarter smarter commented May 10, 2018

Avoid checking a setting value in a hot path.

@smarter
Micro-optimize SymbolLoader#complete
8f73210 
Avoid checking a setting value in a hot path.
Blaisorblade
Blaisorblade approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the -YdebugTrace help string point to Config.tracingEnabled? Or maybe it's OK to let users navigate the source.

@smarter
Copy link
Member Author

smarter commented May 11, 2018

Other uses of -YdebugTrace already required Config.tracingEnabled, it's not an option you want to use without checking what it does anyway.

@smarter smarter merged commit b550d0a into scala:master May 11, 2018
@allanrenucci allanrenucci deleted the opt/complete branch May 11, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blaisorblade Blaisorblade Blaisorblade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smarter @Blaisorblade